Apple has been scanning your photos locally for quite some time now. They've been detecting faces, making collections, finding pets, etc. This is just another step in what they have already been doing.
Processing data locally and maintaining information locally is wholly different from reading (supposedly encrypted) information from your device and reporting it back.
